Make partition_spec as tuple to fix issue #8522 #8613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters or intermediate outputs
tengyifei
approved these changes
Jan 25, 2025
|
@zpcore i made all PR automatically run TPU checks so we don't need the tpuci label now |
|
Thanks! |
zpcore
pushed a commit
that referenced
this pull request
Jan 27, 2025
vealocia
added a commit
to vealocia/xla
that referenced
this pull request
Jan 31, 2025
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make partition_spec as tuple in case any scalar exists in model's parameters or intermediate outputs #8522