Skip to content

Remove stale TODO #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asuhan merged 1 commit into from
Jan 8, 2019
Merged

Remove stale TODO #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion torch_xla/csrc/convolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ Conv2DGrads BuildConv2dBackward(
const xla::PrecisionConfig::Precision conv_precision) {
const auto grad_input =
BuildThnnConv2dBackwardInput(node, grad, input, weight, conv_precision);
// TODO: support weight and bias gradients
const auto grad_weight =
BuildThnnConv2dBackwardWeight(node, grad, input, weight, conv_precision);
auto builder = grad.builder();
Expand Down