Skip to content

Conversation

@ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Nov 26, 2025

This PR improves error handling of LoweringContext::GetOutputOp(), by creating a new LoweringContext::SafeGetOutputOp() function that returns an status-like variable. It also refactors the lowering_context.{h,cpp} C++ files.

Key Changes:

  • Created SafeGetOutputOp(), which is an implementation of GetOutputOp() function, but propagates the error status down the line
    • GetOutputOp() calls SafeGetOutputOp()
    • GetOutputOp() users are not immediately affected
  • Add missing includes (IWYU ref)
  • Remove OutputMap<T> declaration (using PyTorch torch::lazy::OutputMap<T>)

@ysiraichi ysiraichi force-pushed the ysiraichi/better-error-lowering-context-getoutputop branch from 9445d38 to f5f186e Compare December 3, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants