Improve error handling and message of lowering helper functions. #9722
+367
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanyong-wan
requested changes
Dec 2, 2025
| // 3. In the presence of a dynamic shape in the input, we are unable to map | ||
| // it to any of the dimensions of the output | ||
| // | ||
| static absl::StatusOr<std::optional<DynamicReshapeInfo>> |
Collaborator
There was a problem hiding this comment.
Do we still need optional<>? Can we just return an error instead of nullopt?
| // 2. The return value of `get_printable_data(el)` | ||
| template <class T, class FStar, class FPrint = T (*)(T)> | ||
| std::string SpanToStringWithStar( | ||
| absl::Span<const T> span, FStar&& needs_star, |
Collaborator
There was a problem hiding this comment.
Per https://google.github.io/styleguide/cppguide.html#Rvalue_references, avoid Rvalue references here and below.
| // For each element, this function will append to the output string: | ||
| // 1. A star (*), if `needs_star(el)` returns true | ||
| // 2. The return value of `get_printable_data(el)` | ||
| template <class T, class FStar, class FPrint = T (*)(T)> |
Collaborator
There was a problem hiding this comment.
Style: rename FStar to NeedStar, rename FPrint to FormatElement.
| // For each element, this function will append to the output string: | ||
| // 1. A star (*), if `needs_star(el)` returns true | ||
| // 2. The return value of `get_printable_data(el)` | ||
| template <class T, class FStar, class FPrint = T (*)(T)> |
Collaborator
There was a problem hiding this comment.
Why does FPrint return a T instead of a string?
| // 1. The `needs_star` function will also depend on the index of the element | ||
| // 2. It will always print the element, instead of the index (i.e. the | ||
| // `get_printable_data` is already set) | ||
| template <class F> |
Collaborator
There was a problem hiding this comment.
Rename F to NeedStar?
Similar comments for other function templates: make the template type argument names descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error handling and error message of some lowering helper functions found in
helpers.{h,cpp}C++ files.Key Changes:
Safe*versions of the functions:FlattenDynamicReshapeGetDynamicReshapeInfoCheckAtMostOneDynamicDimension()function, a version ofGetDynamicDimensionwith improved error handling and messagesshapeparameter fromSafeFlatten()