Fix EWA ll2cr not handling non-C contiguous arrays#725
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 93.66% 93.68% +0.02%
==========================================
Files 89 89
Lines 13707 13711 +4
==========================================
+ Hits 12838 12845 +7
+ Misses 869 866 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ameraner
approved these changes
May 21, 2026
Member
ameraner
left a comment
There was a problem hiding this comment.
Thank you very much for the quick fix! It solves my issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @ameraner
In #723 it was pointed out that non-C contiguous lon/lat inputs to the EWA ll2cr function are not handled. This PR fixes this by specifying the
orderkwarg toastypeas well as usingnumpy.requireto force write-ability on the inputs. I think this preserves the existing functionality while handling more use cases.The main complication here is that old ll2cr has an optimization if some users want to use it where results are written in-place on the lon/lat inputs to avoid making extra arrays. This of course completely overwrites the lon/lat data in the arrays and is why the default is to copy the data, but I'd still like to support this behavior if it can be used in the future.