Fix reported security issue and get the pages to actually build with never versions of Ruby and Jekyll#57
Merged
adybbroe merged 2 commits intopytroll:mainfrom Oct 16, 2024
Conversation
…rd (old) requirements Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
djhoese
approved these changes
Oct 16, 2024
Member
djhoese
left a comment
djhoese
left a comment
There was a problem hiding this comment.
I'm a little concerned by the versions not being specified for jekyll-feed and minima. From what I remember GitHub limits what version of ruby and jekyll can be used so not specifying the version could lead to some issues. I'm OK merging this though and see how it goes.
Contributor
Author
|
Ok, I get it. I am reverting back to the constraints on versions for those two. It actually works as well. I thought it didn't. Struggled a bit to get the pages to work locally and thought not specifying versions did the thing. It was actually other issues. I have verified this works now as well. |
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a reported security vulnerability issue - concerns a newer version of the activesupport gem
Getting the pages to actually build locally - relaxing some of the hard (old) gem requirements