Fix a bug when sanitizing scoped attribute of style element#25
Merged
encukou merged 3 commits intopyvec:masterfrom Oct 20, 2019
Merged
Fix a bug when sanitizing scoped attribute of style element#25encukou merged 3 commits intopyvec:masterfrom
scoped attribute of style element#25encukou merged 3 commits intopyvec:masterfrom
Conversation
Member
Author
|
Ping |
Member
|
Ow, sorry! I missed the notification :( Do you have a notebook that we could use as a test? |
Member
Author
|
For example this notebook contains a lot of |
encukou
added a commit
to encukou/naucse.python.cz
that referenced
this pull request
Oct 20, 2019
The main update is to naucse 1.1.1, to fix: pyvec/naucse#25
encukou
added a commit
to encukou/naucse.python.cz
that referenced
this pull request
Oct 20, 2019
The main update is to naucse 0.1.1, to fix: pyvec/naucse#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sanitizing
scopedattribute of<style>element it makes sense to do it before DisallowedAttribute exception is raised (because scoped is not in sets of allowed attributes) and it also makes sense tocontinuewhen this attribute is deleted from an element.I've found this bug because notebook files contains style elements with scoped attibutes.