Skip to content

Conversation

@hakonanes
Copy link
Member

Description of the change

Fix #173.

Also changed three diffraction library tests raising errors to also check for the specific error message.

Note that the one line that is not covered in this PR is covered in #182.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in CHANGELOG.rst.

hakonanes added 3 commits June 1, 2022 09:59
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the bug Something isn't working label Jun 1, 2022
@hakonanes hakonanes added this to the v0.5.0 milestone Jun 1, 2022
@hakonanes hakonanes mentioned this pull request Jun 1, 2022
10 tasks
@hakonanes hakonanes requested a review from pc494 June 1, 2022 08:04
Copy link
Member

@pc494 pc494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hakonanes very lazy of me not to pick this one up myself.

@pc494 pc494 merged commit 92aadf2 into pyxem:master Jun 1, 2022
@hakonanes hakonanes deleted the fix-173 branch June 1, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tolerance too high for get_library_entries

2 participants