Starting 0.2.0-rc.1 #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'd quite like to keep the Kirkland scattering factors please - they're a community standard and I think the better solution would be to make them an option in simulations rather than remove them... |
Member
Author
I'll write the refactor to make them accessible in the code, it looked very much like they were unused at present. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Starting 0.2.0-rc.1
about: This is the first PR on the long road to a January 2020 release, my aim is to lean the repo up, and to make as much as possible stable (and correct)
Release Notes
What does this PR do? Please describe and/or link to an open issue.
At the moment mainly deletions and refactors.