Skip to content

Conversation

@pc494
Copy link
Member

@pc494 pc494 commented Oct 17, 2019


name: Starting 0.2.0 rc.1 (Supersedes #29)
about: As previous, with details to follow.


Release Notes

major
improvement & bugfix & developer change

Work in progress?
(more to be added)

  • Kirkland Scattering (move to an issue, and do in a separate PR)
  • PR template
  • debeye waller docstring is slightly wrong (should be dict {str:float} or float)

@dnjohnstone dnjohnstone added this to the v0.2.0 milestone Oct 18, 2019
@dnjohnstone dnjohnstone added bug Something isn't working enhancement New feature, request, or improvement labels Oct 18, 2019
@dnjohnstone
Copy link
Member

I think we need to address #11 in this one to sort saving/loading of libraries etc.

Probably using an hdf5 format is the best route - @stefsmeets I know we discussed this in the past, do you have any opinions / suggestions for this?

@stefsmeets
Copy link
Contributor

Probably using an hdf5 format is the best route - @stefsmeets I know we discussed this in the past, do you have any opinions / suggestions for this?

I agree hdf5 would be most flexible. I tried pickling (also using dill), but it crashed out on me. But I'm worried that hdf5 will be difficult to maintain, because a lot of custom attributes are being stored on different objects (also on pyxem). Hyperspy's BaseSignal already has a .save method, can we not make use of that somehow?

@dnjohnstone
Copy link
Member

Yeah, in pyxem we intend to mostly use the hyperspy.save / load method that already exists.

In the case of simulated libraries though, these things are generated by diffsims, which we're trying to keep a lighter dependency list for. i.e. it does not depend on hyperspy and so we're going to have to do something different...

@dnjohnstone
Copy link
Member

Is this PR dead @pc494 ?

@pc494
Copy link
Member Author

pc494 commented Jan 11, 2020

Yep, I'll pull out the useful stuff somewhere else.

@pc494 pc494 closed this Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature, request, or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants