-
Notifications
You must be signed in to change notification settings - Fork 27
Rotation lists from streographic gridding #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As that's what the docstrings now claim.
|
I'm planning completing the other unticked boxes in a separate PR, which means this is ready for review. |
Could you have a look at the broken tests to start, please? Meanwhile I'll have a look at the rest of it |
dnjohnstone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pc494 this looks pretty good - but like you got bored around docstring time.
I think a few more comments in the code might be helpful too, but not essential.
This does need a pepstorm - but because that might affect other parts of the code and make review tricky let's leave that for a separate pepstorm only PR.
| Nearest neighbour rotations are seperated by a distance of 'resolution' | ||
| equal : 'angle' or 'area' | ||
| See docstrings for diffsims.utils.gridding_utils.get_beam_directions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a brief description here and a "See Also" would be a better solution here.
Saving more emails.
More saved emails
name: Rotation lists from streographic gridding
about: As is industry standard we will provide an implementation of rotation list generation that use streographic triangles. See #52
Release Notes
What does this PR do? Please describe and/or link to an open issue.
At a user level this provides a
rotation_listthat is based on the streographic list, at an internal level this is done by first getting beam directions, and then applying rotations about them, using the'szxz'trick we tried forget_grid_around_beam_direction, with adjustment illustrated by #53. Theoretically it abuses spherical polar coordinates, as most reduced regions are defined by lines of "longtitude" and the equator, which puts hard limits on theta and phi. The exception is the cubic case.Work in progress?
If you know there is more to do, make a checklist here:
StructureLibrarycompliant with all these changes** Script for checking IPZ figures **
Making use of the headline formulae from https://en.wikipedia.org/wiki/Stereographic_projection#Visualization_of_lines_and_planes