-
Notifications
You must be signed in to change notification settings - Fork 27
Rotation lists from streographic gridding #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
0ceb157
Scopes out get_rotation_list_streographic
pc494 7849b88
Callsign for get_beam_directions
pc494 996c1d9
Adds crystal system dictionary
pc494 2cbaa22
Call to crystal system dictionary
pc494 befec05
Including (no implementation) equal area
pc494 54ae5de
Adds equal='angle' functionality
pc494 9c3ec2d
Scoping the later stages of get_beam_direction
pc494 15d99c8
vectorised_to_spherical_polars
pc494 99dfc25
Finishing up get_beam_directions
pc494 0308cd8
Building the beam direction spins for get_grid_streographic
pc494 20c2ca7
Including the reshape discovered when making #53
pc494 57ffeec
Adds an assertionless test to check nothing is very broken
pc494 94315d4
Fixes for the obvious/easy broke stuff
pc494 cb482a7
Adding a missed transpose
pc494 c6dda28
Tidying up some numpy array bits
pc494 0464ca7
Normalising axes
pc494 8d8f2c3
axis --> axes
pc494 72e0d65
Line refactor for readability
pc494 50517e2
Downstream function returns Euler so no need to convert
pc494 edcd193
syntax error
pc494 593ed5a
fix order a crystal_system,resolution
pc494 a906c7b
Syntax fix for hstack brackets
pc494 c749646
Drop a poor bit of array selection and an erronous rad2deg
pc494 b798582
test non-cubic and cubic sep
pc494 23714c8
scoping out the cubic functionality
pc494 00f37de
Fixing typos
pc494 67ab6a6
vectorising internal geodesic functionality
pc494 14c48e7
Adding a missing transpose
pc494 0bd56bd
Avoids normalising by the [0,0,0] axis
pc494 55a584d
Fix a typo
pc494 171b4aa
Assertioned testing for get_grid_streographic
pc494 47c95fd
Fix a syntax error
pc494 a60376a
Modularising get_beam_directions for testing purposes
pc494 ef13e28
test_get_beam_direction implemented
pc494 71bb311
Shortening the top level testing
pc494 a9f31ee
Fix a typo, and switch a dot product
pc494 e0bb36e
Another typo fixed
pc494 a2e531e
cubic case tests
pc494 a6d2dbb
Clarification if/else clause
pc494 a72e962
degree --> radians
pc494 e4d63ab
Isolates the cause of the hexagonal/trigonal failure
pc494 4926863
Fixing the theta=0 degenracy for case when psi is never 0
pc494 e00fb12
being a bit more generous, as our edge sampling system is a bit odd
pc494 0a86320
adding equal area option
pc494 8c72949
Adds an equal area test
pc494 396605f
Feeding equal through to top level function
pc494 9feda32
testing equal arguments
pc494 7448b17
[ci skip] Detailed docstrings for get_beam_directions
pc494 69137ce
minor clarity adjustments
pc494 804eb02
[ci skip] docstrings for vectorised_spc2cart
pc494 6f6793d
[ci skip] docstring 4 beam_direction2euler_angles
pc494 e87b384
Tests area&angle generate same number of points
pc494 980ab99
Merge pull request #1 from pc494/pc494-small-adjustments-for-streogri…
pc494 e5eea80
bugfix + docstrings
pc494 b2fe30d
Fixes a testing syntax typo
pc494 3a06c4c
Merge pull request #2 from pc494/local-fix-beam-directions
pc494 e4459ef
Fix syntax error in tests
pc494 6239caa
docstring corrections
pc494 edde0f0
'none' to 'triclinic'
pc494 41fee7a
global import rather than local for 'product'
pc494 c08eab3
Docstrings for rotate_axangles
pc494 3bb6df9
Merge pull request #3 from pc494/lcl-fbd-2
pc494 53ca196
Update rotation_list_generators.py
dnjohnstone 9a7bc4e
Update gridding_utils.py
dnjohnstone eba0b4b
Update gridding_utils.py
dnjohnstone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.