Fix file permissions#726
Merged
svivian merged 1 commit intoq2a:bugfixfrom Jan 12, 2019
Merged
Conversation
Collaborator
|
Thanks, and yes it would make sense to ignore htaccess, since people may customize it themselves and don't want to overwrite it with a new Q2A version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unrelated to this, I'm also thinking that there are a few issues with the
.gitignoreand the.htaccessfiles.The
.gitignorefile should ignore the.htaccessfile. The.htaccessfile should be treated as server-dependent in the same way as theqa-config.phpfile and be included as an example file.Also the
.gitignorefor both the.htaccessand theqa-config.phpfile should also ignore only those two files that reside in that same directory. Currently it is ignoring all files with that name even if they are located in subdirectories.If these changes make sense I can commit them to this branch.