Fix many issues regarding $errors variable and @ character#894
Merged
svivian merged 1 commit intoq2a:bugfixfrom May 3, 2021
Merged
Fix many issues regarding $errors variable and @ character#894svivian merged 1 commit intoq2a:bugfixfrom
svivian merged 1 commit intoq2a:bugfixfrom
Conversation
Collaborator
|
Thanks for this. We ought to move to PHP 7 minimum soon, so we can write |
Contributor
Author
|
I know, I'm looking forward for that to happen :) The PHP 8 release can be used as an excuse for this dependency update. The good thing of having the wordy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed many usages of the @ sign and initialized the
@errorsvariable in all pages I noticed it was used.I have not removed all @ signs, but this should get the code one step closer to that.
This PR should also fix #888.