Conversation
- Added SVG light and dark mode versions of PyQASM logo. - Added dynamic logo mode to README.md based on color palette used on user-side.
|
🚫 Logo Change Blocked Changes to Why is this blocked?
What should you do?
Files changed in this PR: |
|
🚫 Logo Change Blocked Changes to Why is this blocked?
What should you do?
Files changed in this PR: |
|
@ryanhill1 shall I remove the |
There was a problem hiding this comment.
Hi @ACE07-Sev, thanks for this PR! Your updates look really good. I like the font you chose as well.
Don't worry about the Logo check action failing.
Could you trim the dimension of the images to eliminate the empty space around the outsides?
And could you also provide the source file or Figma design that you used to generate the images?
Of course, will do.
I actually just built it piece by piece using inkscape, which outputs the svg (which is basically vector code that'll output the visualization). There's not really a script that generates this. The svg is the source file. Unlike png or jpg, this is resolution-agnostic, so you can resize without it getting blurred since it renders depending on available resolution. |
|
🚫 Logo Change Blocked Changes to Why is this blocked?
What should you do?
Files changed in this PR: |
|
🚫 Logo Change Blocked Changes to Why is this blocked?
What should you do?
Files changed in this PR: |
ryanhill1
left a comment
There was a problem hiding this comment.
@ACE07-Sev These updates look good! Can you just comment on the original issue so that I can assign you to it so that you get credit through unitaryDESIGN?
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary of changes
closes #287 .