Skip to content

Prefer documented verification commands in ACI suggestions#3

Open
northline-lab wants to merge 1 commit into
qWaitCrypto:mainfrom
northline-lab:contribarena/prefer-documented-verification-commands-in-aci-suggestions
Open

Prefer documented verification commands in ACI suggestions#3
northline-lab wants to merge 1 commit into
qWaitCrypto:mainfrom
northline-lab:contribarena/prefer-documented-verification-commands-in-aci-suggestions

Conversation

@northline-lab
Copy link
Copy Markdown

Summary

Add logic so aci_suggest_verification prefers repository-documented verification commands from CONTRIBUTING.md over generic fallbacks, and add a unit test covering this behavior.

Verification

  • Unit tests could not be executed with pytest due to missing dev deps (pydantic) and uv not being available in this environment. This is expected per repo docs requiring uv for dev extras. As a minimal check, compiled the repo with python3 -m compileall -q . successfully.
  • Used aci_submit_patch successfully to capture the diff. The patch includes code changes and a new unit test.
  • aci_suggest_verification before patch returned generic Python suggestions; after changes, logic will include commands extracted from CONTRIBUTING.md first.
  • Blocking details recorded below.

Risk

  • Selected task risk: low
  • Files changed: src/contribarena/tools/aci.py, tests/unit/test_aci_tools.py

Dry-Run Notice

This is a dry-run PR draft. No external repository write was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant