Skip to content

make get_qase_ids public#487

Closed
Jrendl wants to merge 1 commit into
qase-tms:mainfrom
Jrendl:get-qase-ids-public
Closed

make get_qase_ids public#487
Jrendl wants to merge 1 commit into
qase-tms:mainfrom
Jrendl:get-qase-ids-public

Conversation

@Jrendl
Copy link
Copy Markdown

@Jrendl Jrendl commented May 13, 2026

We have a use case where we need to augment the qase test collection logic within our own pytest plugin. Being able to get the qase ids associated with a testcase is important for that use case. I don't see why this method needs to be protected so I've just modified the signature to make it public. If there's a specific reason this needs to be protected please let me know!

@gibiw
Copy link
Copy Markdown
Contributor

gibiw commented May 14, 2026

Thanks for the contribution, @Jrendl! The rename itself was the right call, but the original patch only updated the method definition and left the two internal call sites (pytest_collection_modifyitems filtering on line 104 and the single-project testops_ids assignment on line 433) plus all test_plugin.py references on the old _get_qase_ids name, which would have broken the plugin.

I picked the change up in #490, fixed the call sites and tests, bumped the version, and updated the changelog. It is now released as qase-pytest 8.3.0QasePytestPlugin.get_qase_ids(item) is available as a public static method. Closing this PR in favor of #490.

@gibiw gibiw closed this May 14, 2026
@Jrendl
Copy link
Copy Markdown
Author

Jrendl commented May 14, 2026

Thanks for the contribution, @Jrendl! The rename itself was the right call, but the original patch only updated the method definition and left the two internal call sites (pytest_collection_modifyitems filtering on line 104 and the single-project testops_ids assignment on line 433) plus all test_plugin.py references on the old _get_qase_ids name, which would have broken the plugin.

I picked the change up in #490, fixed the call sites and tests, bumped the version, and updated the changelog. It is now released as qase-pytest 8.3.0QasePytestPlugin.get_qase_ids(item) is available as a public static method. Closing this PR in favor of #490.

Ah good catch!! My bad for not doing a full sweep with the rename. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants