You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a use case where we need to augment the qase test collection logic within our own pytest plugin. Being able to get the qase ids associated with a testcase is important for that use case. I don't see why this method needs to be protected so I've just modified the signature to make it public. If there's a specific reason this needs to be protected please let me know!
Thanks for the contribution, @Jrendl! The rename itself was the right call, but the original patch only updated the method definition and left the two internal call sites (pytest_collection_modifyitems filtering on line 104 and the single-project testops_ids assignment on line 433) plus all test_plugin.py references on the old _get_qase_ids name, which would have broken the plugin.
I picked the change up in #490, fixed the call sites and tests, bumped the version, and updated the changelog. It is now released as qase-pytest 8.3.0 — QasePytestPlugin.get_qase_ids(item) is available as a public static method. Closing this PR in favor of #490.
Thanks for the contribution, @Jrendl! The rename itself was the right call, but the original patch only updated the method definition and left the two internal call sites (pytest_collection_modifyitems filtering on line 104 and the single-project testops_ids assignment on line 433) plus all test_plugin.py references on the old _get_qase_ids name, which would have broken the plugin.
I picked the change up in #490, fixed the call sites and tests, bumped the version, and updated the changelog. It is now released as qase-pytest 8.3.0 — QasePytestPlugin.get_qase_ids(item) is available as a public static method. Closing this PR in favor of #490.
Ah good catch!! My bad for not doing a full sweep with the rename. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a use case where we need to augment the qase test collection logic within our own pytest plugin. Being able to get the qase ids associated with a testcase is important for that use case. I don't see why this method needs to be protected so I've just modified the signature to make it public. If there's a specific reason this needs to be protected please let me know!