Skip to content

Conversation

@jinzhu
Copy link
Contributor

@jinzhu jinzhu commented Nov 16, 2017

Seems like we need to change import path to github.com/360EntSecGroup-Skylar/excelize?

@codecov-io
Copy link

codecov-io commented Nov 16, 2017

Codecov Report

Merging #153 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          14       14           
  Lines        3171     3171           
=======================================
  Hits         3122     3122           
  Misses         30       30           
  Partials       19       19
Impacted Files Coverage Δ
cell.go 99.26% <ø> (ø) ⬆️
picture.go 99.23% <ø> (ø) ⬆️
chart.go 99.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b3e1e...21214a5. Read the comment docs.

@xuri xuri merged commit 4436957 into qax-os:master Dec 1, 2017
@javasgl
Copy link

javasgl commented Aug 26, 2019

import path "github.com/360EntSecGroup-Skylar/excelize/v2" was a little bit ugly.

SHOULD BE lowercase-without-dash witch is recommend by golang

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants