Add internal, external unit price and service provider in products #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KochTobi
approved these changes
Jul 23, 2021
Comment on lines
+48
to
+63
|
|
||
| /** | ||
| * Basic product constructor. | ||
| * | ||
| * Checks that all passed arguments are not null. | ||
| * | ||
| * @param name The name of the product. | ||
| * @param description The description of what the product is about. | ||
| * @param internalUnitPrice The price in € per unit for internal customers | ||
| * @param externalUnitPrice The price in € per unit for external customers | ||
| * @param unit The product unit | ||
| * @param runningNumber Number used in conjunction with ProductType{@link life.qbic.datamodel.dtos.business.services.ProductType} to identify product | ||
| * @param serviceProvider The facility providing the service product | ||
| * | ||
| * @since 2.11.0 | ||
| */ |
|
i need to update the CL on sec |
KochTobi
requested changes
Jul 23, 2021
src/main/groovy/life/qbic/datamodel/dtos/business/services/Product.groovy
Outdated
Show resolved
Hide resolved
KochTobi
reviewed
Jul 23, 2021
src/main/groovy/life/qbic/datamodel/dtos/business/services/Product.groovy
Outdated
Show resolved
Hide resolved
KochTobi
reviewed
Jul 23, 2021
src/main/groovy/life/qbic/datamodel/dtos/business/services/Product.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
KochTobi
approved these changes
Jul 23, 2021
Merged
KochTobi
added a commit
that referenced
this pull request
Aug 3, 2021
2.11.0 (2021-08-03) ---------------------------- **Added** * A new enumeration for facilities ``life.qbic.datamodel.dtos.business.facilities.Facility`` (<#244>) * New properties ``internalUnitPrice``, ``externalUnitPrice`` and ``serviceProvider`` for the ``life.qbic.datamodel.dtos.business.services.Product`` and its derivatives (<#245>) * New properties ``totalPrice`` and ``totalDiscountPrice`` for the ``life.qbic.datamodel.dtos.business.ProductItem`` and ``totalDiscountPrice`` for the ``life.qbic.datamodel.dtos.business.Offer`` * A ``life.qbic.datamodel.dtos.business.facilities.FacilityFactory`` to get the facility for a given string representation (<#247>) **Fixed** * ProjectSpace names are now validated (<#249>) **Dependencies** **Deprecated** * The ``unitPrice`` property in ``life.qbic.datamodel.dtos.business.services.Product``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
Productsclass family with new properties: