Feature facility factory #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1103
reviewed
Jul 27, 2021
| @Override | ||
| Facility getForString(String value) { | ||
| Facility desiredKey | ||
| desiredKey = Facility.values().find {it.fullName.equals(value.trim())} |
There was a problem hiding this comment.
what is Facility.values() returning?
There was a problem hiding this comment.
all the enum values e.g. Facility.QBIC
There was a problem hiding this comment.
> import life.qbic.datamodel.dtos.business.facilities.Facility
>
> Facility.values()
Result: [Core Facility for Medical Bioanalytics, Institute for Medical Genetics and Applied Genomics, Institute for Medical Microbiology and Hygiene, Quantitative Biology Center, Proteome Center Tübingen]
NOTE: toString() is called because of the print done by groovy
sven1103
reviewed
Jul 27, 2021
| Facility desiredKey | ||
| desiredKey = Facility.values().find {it.fullName.equals(value.trim())} | ||
| if (!desiredKey) { | ||
| throw new IllegalArgumentException("Invalid value '$value' for ${Facility.getSimpleName()}") |
There was a problem hiding this comment.
What is Facility.getSimpleName() returning?
There was a problem hiding this comment.
Facility
> import life.qbic.datamodel.dtos.business.facilities.Facility
>
> Facility.simpleName
Result: Facility
sven1103
approved these changes
Jul 27, 2021
Merged
KochTobi
added a commit
that referenced
this pull request
Aug 3, 2021
2.11.0 (2021-08-03) ---------------------------- **Added** * A new enumeration for facilities ``life.qbic.datamodel.dtos.business.facilities.Facility`` (<#244>) * New properties ``internalUnitPrice``, ``externalUnitPrice`` and ``serviceProvider`` for the ``life.qbic.datamodel.dtos.business.services.Product`` and its derivatives (<#245>) * New properties ``totalPrice`` and ``totalDiscountPrice`` for the ``life.qbic.datamodel.dtos.business.ProductItem`` and ``totalDiscountPrice`` for the ``life.qbic.datamodel.dtos.business.Offer`` * A ``life.qbic.datamodel.dtos.business.facilities.FacilityFactory`` to get the facility for a given string representation (<#247>) **Fixed** * ProjectSpace names are now validated (<#249>) **Dependencies** **Deprecated** * The ``unitPrice`` property in ``life.qbic.datamodel.dtos.business.services.Product``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a facility factory