Skip to content

Remove field access modifiers from DTOs #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2020
Merged

Remove field access modifiers from DTOs #52

merged 3 commits into from
Aug 27, 2020

Conversation

@KochTobi
Copy link
Member

This addresses #51

@KochTobi KochTobi linked an issue Aug 27, 2020 that may be closed by this pull request
DTO getter methods not generated #51
Closed
@codecov
Copy link

codecov bot commented Aug 27, 2020 •
edited
Loading

Codecov Report

Merging #52 into development will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             development      #52      +/-   ##
=================================================
+ Coverage          18.56%   18.64%   +0.08%     
  Complexity           169      169              
=================================================
  Files                101      101              
  Lines               1794     1786       -8     
  Branches             237      237              
=================================================
  Hits                 333      333              
+ Misses              1409     1401       -8     
  Partials              52       52
Impacted Files Coverage Δ Complexity Δ
...oovy/life/qbic/datamodel/dtos/imaging/Image.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...life/qbic/datamodel/dtos/imaging/Instrument.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...y/life/qbic/datamodel/dtos/imaging/Location.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...os/imaging/parameters/AcquisitionParameters.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tronmicroscopy/ElectronMicroscopyParameters.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...s/lightmicroscopy/LightMicroscopyParameters.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...qbic/datamodel/dtos/imaging/properties/Area.groovy 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../datamodel/dtos/imaging/properties/Detector.groovy 100.00% <ø> (ø) 1.00 <0.00> (ø)
...odel/dtos/imaging/properties/Dimensionality.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...model/dtos/imaging/properties/EmissionRange.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3b72a...582d977. Read the comment docs.

@KochTobi KochTobi requested a review from a team August 27, 2020 09:09
@KochTobi KochTobi mentioned this pull request Aug 27, 2020
Open
Steffengreiner
Steffengreiner approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@Steffengreiner Steffengreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I find your solution pretty 💮 "groovy" 💮

@KochTobi KochTobi merged commit 666dfd2 into development Aug 27, 2020
@KochTobi KochTobi deleted the fix/imaging/field-accessibility branch August 27, 2020 12:13
KochTobi added a commit that referenced this pull request Aug 27, 2020
@KochTobi
Update CHANGELOG.md for #52
c27efa2
KochTobi added a commit that referenced this pull request Aug 28, 2020
@KochTobi @sven1103
Patch/1.10.1 (#54)
62d7ef1 
* Increase version to 1.11.0-SNAPSHOT

* Fix wrong x-ref syntax in Groovydoc

* Fix wrong Groovydoc syntax

* Ignore generated flattened-pom.xml

* Remove field access modifiers from DTOs (#52)

* Add enum final modifier to value

* Update CHANGELOG.md

* Set version to 1.10.1

Co-authored-by: Sven Fillinger <sven.fillinger@qbic.uni-tuebingen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steffengreiner Steffengreiner Steffengreiner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DTO getter methods not generated

3 participants

@KochTobi @Steffengreiner