-
Notifications
You must be signed in to change notification settings - Fork 3
Add documentation for NGS data with metadata #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jenniferboedker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Other then that LGTM
| **Disclaimer!** | ||
| This data format is targeted for a single use case and should not be | ||
| used for general data registration purposes. Please use the | ||
| [NGS single-end / paired-end data](#ngs-single-end--paired-end-data) | ||
| format for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe point out what differentiates the two registration processes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats deep business, i actually would not like to have it here.
| ``` | ||
| { | ||
| "files": [ | ||
| "reads.1.fastq.gz", | ||
| "reads.2.fastq.gz" | ||
| ], | ||
| "type": "dna_seq", | ||
| "sample1": { | ||
| "genome": "GRCh37", | ||
| "id_genetics": "GS000000_01", | ||
| "id_qbic": "QTEST002AE", | ||
| "processing_system": "Test system", | ||
| "tumor": "no" | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like the example!
| <QBIC sample code> // Directory | ||
| |-- file1.fastq.gz | ||
| |-- file2.fastq.gz | ||
| |-- metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe make it more explicit
| |-- metadata | |
| |-- metadata.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, its metadata :) the script does not look for the json extension.
| Example sample ids: | ||
|
|
||
| QABCD001AE (Analyte, Q_TEST_SAMPLE) | ||
| NGS[0-9]{2}QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we also give example for the codes I think its ok to also avoid the regex here
| NGS[0-9]{2}QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where | |
| NGS23QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is important to now, how the code will look like. It will be always to digit, from 00-99.
| Q_TEST_SAMPLE -> Q_NGS_SINGLE_SAMPLE_RUN (with sample code) -> DataSet | ||
| of type Q_NGS_RAW_DATA (directory with raw sequencing files contained) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot verify if this is the structure. I did not find an openbis project for that so I will trust you here :)
jenniferboedker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.