Skip to content

Conversation

@sven1103
Copy link
Contributor

No description provided.

@sven1103
Copy link
Contributor Author

Copy link
Contributor

@jenniferboedker jenniferboedker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Other then that LGTM

Comment on lines +87 to +91
**Disclaimer!**
This data format is targeted for a single use case and should not be
used for general data registration purposes. Please use the
[NGS single-end / paired-end data](#ngs-single-end--paired-end-data)
format for now.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe point out what differentiates the two registration processes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats deep business, i actually would not like to have it here.

Comment on lines +125 to +140
```
{
"files": [
"reads.1.fastq.gz",
"reads.2.fastq.gz"
],
"type": "dna_seq",
"sample1": {
"genome": "GRCh37",
"id_genetics": "GS000000_01",
"id_qbic": "QTEST002AE",
"processing_system": "Test system",
"tumor": "no"
}
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the example!

<QBIC sample code> // Directory
|-- file1.fastq.gz
|-- file2.fastq.gz
|-- metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make it more explicit

Suggested change
|-- metadata
|-- metadata.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, its metadata :) the script does not look for the json extension.

Example sample ids:

QABCD001AE (Analyte, Q_TEST_SAMPLE)
NGS[0-9]{2}QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we also give example for the codes I think its ok to also avoid the regex here

Suggested change
NGS[0-9]{2}QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where
NGS23QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important to now, how the code will look like. It will be always to digit, from 00-99.

Comment on lines +97 to +98
Q_TEST_SAMPLE -> Q_NGS_SINGLE_SAMPLE_RUN (with sample code) -> DataSet
of type Q_NGS_RAW_DATA (directory with raw sequencing files contained)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot verify if this is the structure. I did not find an openbis project for that so I will trust you here :)

Copy link
Contributor

@jenniferboedker jenniferboedker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sven1103 sven1103 merged commit fb8b5a5 into master Feb 26, 2021
@sven1103 sven1103 deleted the docs/register-imgag-dropbox branch February 26, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants