Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ openBIS.
Formats:

- [NGS single-end / paired-end data](#ngs-single-end--paired-end-data)
- [NGS single-end / paired-end data with metadata (deprecated)](#ngs-single-end--paired-end-data-with-metadata-(deprecated))

### NGS single-end / paired-end data

Expand Down Expand Up @@ -81,4 +82,59 @@ look like this:
|-- <QBIC sample code>.fastq.gz.sha256sum
```

### NGS single-end / paired-end data with metadata (deprecated)

**Disclaimer!**
This data format is targeted for a single use case and should not be
used for general data registration purposes. Please use the
[NGS single-end / paired-end data](#ngs-single-end--paired-end-data)
format for now.
Comment on lines +87 to +91
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe point out what differentiates the two registration processes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats deep business, i actually would not like to have it here.


**Responsible dropbox:**
[QBiC-register-imgag-dropbox](drop-boxes/register-imgag-dropbox)

**Resulting data model in openBIS**
Q_TEST_SAMPLE -> Q_NGS_SINGLE_SAMPLE_RUN (with sample code) -> DataSet
of type Q_NGS_RAW_DATA (directory with raw sequencing files contained)
Comment on lines +97 to +98
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot verify if this is the structure. I did not find an openbis project for that so I will trust you here :)


Example sample ids:

QABCD001AE (Analyte, Q_TEST_SAMPLE)
NGS[0-9]{2}QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we also give example for the codes I think its ok to also avoid the regex here

Suggested change
NGS[0-9]{2}QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where
NGS23QABCS001AE (Sequencing Result, Q_NGS_SINGLE_SAMPLE_RUN) where

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important to now, how the code will look like. It will be always to digit, from 00-99.

the running two-digit number is taken from the identifier suffix from
the `genetics_id` in the metadata file.

**Description**
For paired-end sequencing reads in FASTQ format, the file structure
needs to look like this

```
<QBIC sample code> // Directory
|-- file1.fastq.gz
|-- file2.fastq.gz
|-- metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make it more explicit

Suggested change
|-- metadata
|-- metadata.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, its metadata :) the script does not look for the json extension.

|- ...
```

**Expected metadata**
Additional metadata is required in this format case and expected to be
noted in JSON in a file called `metadata` and following the
[upload metadata schema](drop-boxes/register-imgag-dropbox/upload-metadata.schema.json).
A valid JSON object can look like this:

```
{
"files": [
"reads.1.fastq.gz",
"reads.2.fastq.gz"
],
"type": "dna_seq",
"sample1": {
"genome": "GRCh37",
"id_genetics": "GS000000_01",
"id_qbic": "QTEST002AE",
"processing_system": "Test system",
"tumor": "no"
}
}
```
Comment on lines +125 to +140
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the example!

42 changes: 0 additions & 42 deletions drop-boxes/register-imgag-dropbox/README.md

This file was deleted.