Skip to content

fix: use original jina de model instead of fp16 due to onnxruntime up…#623

Merged
joein merged 2 commits intomainfrom
use-original-jina-de-model
Apr 15, 2026
Merged

fix: use original jina de model instead of fp16 due to onnxruntime up…#623
joein merged 2 commits intomainfrom
use-original-jina-de-model

Conversation

@joein
Copy link
Copy Markdown
Member

@joein joein commented Apr 8, 2026

Starting from onnxruntime 1.23, model_fp16.onnx started failing with onnxruntime not supporting a custom layer in fp16 version of jinaai/jina-embeddings-v2-base-de, in order to mitigate this issue, I propose to replace fp16 model with the original fp32

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9cf8efb-c122-4482-8cdc-4ddc8a9c66a6

📥 Commits

Reviewing files that changed from the base of the PR and between 21df54e and 85514e6.

📒 Files selected for processing (2)
  • fastembed/text/pooled_normalized_embedding.py
  • fastembed/text/text_embedding.py

📝 Walkthrough

Walkthrough

These changes update the model configuration and compatibility warnings for the jina-embeddings-v2-base-de model across two files. The first file increases the reported model size from 0.32 GB to 0.64 GB and updates the ONNX artifact path from onnx/model_fp16.onnx to onnx/model.onnx. The second file removes two outdated compatibility warnings for other models and introduces a new warning specific to jina-embeddings-v2-base-de that explains the change from fp16 to fp32 execution due to onnxruntime updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: replacing the fp16 model with the original fp32 model for jinaai/jina-embeddings-v2-base-de due to onnxruntime compatibility issues.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation (onnxruntime 1.23 incompatibility with fp16 custom layer) and the solution (switching to original fp32 model).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch use-original-jina-de-model

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joein joein requested a review from tbung April 9, 2026 10:25
@joein joein merged commit a6a4e37 into main Apr 15, 2026
13 checks passed
@joein joein deleted the use-original-jina-de-model branch April 15, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants