test: add tests for hybrid cloud environment extra flags#85
Merged
Davidonium merged 1 commit intofeat/dhernando/hybrid-cloud-environment-extra-flagsfrom Mar 31, 2026
Conversation
Cover the new flags added to hybrid cluster create, update, and describe commands: package resolution (by name, CPU/RAM, mutual exclusivity, disk calculation), cluster config (restart-policy, rebalance-strategy, topology-spread-constraint, cost-allocation-label), storage config (all 4 storage class flags), and database config (db-log-level, vectors-on-disk, TLS, secrets, audit logging). Also adds unit tests for the new helper parsers/formatters, CalculateAdditionalDisk, util.IsUUID, and util.AnyFlagChanged. Fixes existing create tests that broke due to mandatory package resolution. Made-with: Cursor
Davidonium
merged commit 31d5eff
into
feat/dhernando/hybrid-cloud-environment-extra-flags
4 checks passed
Davidonium
deleted the
feat/dhernando/hybrid-cloud-environment-extra-flags-tests
branch
Davidonium
added a commit
that referenced
this pull request
Mar 31, 2026
* feat: add missing flags to the hybrid environment clusters * refactor: add resources flags to hybrid cluster command and calculate package / additional disk changes * refactor: remove gpu related flags on the hybrid cloud cluster commands, refactor package resolving so that it uses a struct instead of a thousand parameters * refactor: move wait flags to the end, remove gpu-type flag for now * refactor: make use of util.AnyFlagChanged in cluster create * test: add tests for hybrid cloud environment extra flags (#85) Cover the new flags added to hybrid cluster create, update, and describe commands: package resolution (by name, CPU/RAM, mutual exclusivity, disk calculation), cluster config (restart-policy, rebalance-strategy, topology-spread-constraint, cost-allocation-label), storage config (all 4 storage class flags), and database config (db-log-level, vectors-on-disk, TLS, secrets, audit logging). Also adds unit tests for the new helper parsers/formatters, CalculateAdditionalDisk, util.IsUUID, and util.AnyFlagChanged. Fixes existing create tests that broke due to mandatory package resolution. Made-with: Cursor Co-authored-by: Qdrant Claw <qdrant-claw@qdrant.com> --------- Co-authored-by: qdrant-cloud-bot <111755117+qdrant-cloud-bot@users.noreply.github.com> Co-authored-by: Qdrant Claw <qdrant-claw@qdrant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hybrid cluster create,hybrid cluster update, andhybrid cluster describeparseRestartPolicy,parseRebalanceStrategy,parseGpuType,parseDBLogLevel,parseAuditLogRotation,parseTopologySpreadConstraint,parseSecretKeyRef)clusterutil.CalculateAdditionalDiskutil.IsUUIDandutil.AnyFlagChangedCreate tests (7 new)
PackageByName--packagewith a name stringPackageByCPUAndRAM--cpu+--ramresource resolutionPackageMutualExclusion--package+--cpurejectsPackageWithDisk--diskadditional disk calculationClusterConfigFlagsStorageConfigFlagsDatabaseConfigFlagsUpdate tests (3 new)
ClusterConfigFlagsStorageAndResourceFlagsExtendedDBConfig_WithForceDescribe tests (1 new)
NewFieldsTest plan
make lintpassesmake buildpassesgo test ./internal/cmd/hybrid/... ./internal/cmd/clusterutil/... ./internal/cmd/util/...)Made with Cursor