chore: update dependencies#283
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
In tonic 0.14, prost integration was extracted into separate crates tonic-prost (runtime) and tonic-prost-build (codegen). Add both and update tests/protos.rs accordingly. prost-build 0.14 also auto-derives Eq and Hash for messages where possible, which clashes with the manual `impl Hash for PointId` in extensions.rs; the manual impl is dropped in favor of the derive. The field-level `#[deprecated(since = ..., note = ...)]` attributes for deprecated oneof variants are no longer applied via configure_deprecations because tonic-prost-build now emits a plain `#[deprecated]` from the proto annotation itself, which conflicted with the manual one. The generated src/qdrant.rs is regenerated with the new toolchain. Co-authored-by: Cursor <cursoragent@cursor.com>
reqwest 0.13 renamed the `rustls-tls` feature to `rustls`; update the feature list accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
Updates the crate’s Rust dependency set (based on cargo outdated/audit) and adapts the protobuf/tonic codegen pipeline for tonic/prost 0.14, including regenerating the vendored gRPC stubs.
Changes:
- Bumped core dependencies (notably
tonic,prost,reqwest,tokio,uuid,thiserror) and adjusted feature flags accordingly. - Switched proto compilation in
tests/protos.rsfromtonic_buildtotonic_prost_buildand updated deprecation-attribute customization to avoid collisions. - Regenerated
src/qdrant.rswith the new toolchain (includingtonic_prost::ProstCodecusage and updated body types).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Cargo.toml |
Updates dependency versions/features and adds the new split tonic/prost integration crates. |
tests/protos.rs |
Moves proto build/test generation to tonic_prost_build and removes conflicting manual deprecation attributes. |
src/qdrant.rs |
Regenerated vendored protobuf/gRPC code for the upgraded tonic/prost toolchain. |
src/grpc_conversions/extensions.rs |
Removes manual Hash impl for PointId to align with new derives from prost 0.14. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agourlay
approved these changes
May 26, 2026
Member
agourlay
left a comment
There was a problem hiding this comment.
I have tested this branch with bfb and crasher 👍
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ffuugoo
approved these changes
May 26, 2026
timvisee
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bulk dependency upgrade based on
cargo outdated/audit report. One commit per dependency.Notes on breaking upgrades
tonic-prostis added as a runtime dependency andtonic-prost-buildas a dev dependency.tests/protos.rswas updated to usetonic_prost_buildinstead oftonic_buildfor proto compilation. TLS features were changed from the deprecatedtls/tls-rootstotls-ring/tls-native-roots.Eq/Hashfor messages where all fields support it. The manualimpl Hash for PointIdclashed with the new derive and was removed.configure_deprecationshelper intests/protos.rsno longer adds field attributes forPointsUpdateOperation.{delete,clear_payload}_deprecated.tonic-prost-buildnow emits a plain#[deprecated]for them based on the protodeprecated = trueoption, which collided with the manually added detailed attribute.src/qdrant.rswas regenerated with the new toolchain (this commit is folded into thetonic-buildbump commit).rustls-tlsfeature torustls; the feature list inCargo.tomlwas adjusted.#[error(...)]/#[from]/#[source]usage is compatible.Test plan
cargo build --all-featurescargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo test --all-features --test protoscargo test --all-features --test builder_coveragecargo test --all-features --lib(only failures are 3 tests that require a running Qdrant server onlocalhost:6334)Made with Cursor