Advise mmap to cleanup closed segments#108
Merged
Conversation
JojiiOfficial
force-pushed
the
cleanup-closed-segment-memory
branch
from
ae49df4 to
3c6d51b
Compare
6 tasks
timvisee
reviewed
Feb 17, 2026
Comment on lines
+1002
to
+1007
| if until < entry_count { | ||
| // If `until` is (much) lower we might retain more to satisfy prefix_truncate | ||
| wal.closed_segments.len() >= retain_closed | ||
| } else { | ||
| wal.closed_segments.len() == retain_closed | ||
| } |
Member
There was a problem hiding this comment.
until is randomized and might be very small. If so, we might retain more segments than configured to satisfy the prefix_truncate above.
This fixes the test by also allowing us to keep more retained segments.
timvisee
changed the title
timvisee
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.