System prompt editable#19
Merged
Merged
Conversation
…avigation hooks in tests
…elated functionality
… shared utilities - Moved chat proxy tests from `chat_proxy.test.js` to `chat_proxy.proxy.test.js` for better organization. - Introduced `helpers/chatProxyTestUtils.js` to encapsulate common test setup and mock server logic. - Updated tests to utilize the new shared utilities for creating mock upstream servers and handling requests. - Ensured all existing test cases are preserved and function correctly in the new structure.
…file and update import paths
…th role attributes, and remove unused provider enable toggle
…sistency and accessibility
…debar, and RightSidebar for improved visual consistency
…ations editing, and providers API
…e testability - Replaced direct `node-fetch` usage with dependency-injected HTTP client in `createProvidersRouter`. - Updated tests to use dependency injection for mocking upstream responses in provider-related API tests. - Improved maintainability and flexibility by modularizing providers router creation. - Suppressed migration logs during test runs to declutter test output.
- Replaced direct `node-fetch` imports with dependency-injected HTTP client for flexibility and testability. - Updated `callLLM` and orchestration functions to accept custom HTTP client arguments. - Refactored tests to use mocked HTTP clients, removing reliance on global `node-fetch` mocks. - Enhanced maintainability by centralizing HTTP client configuration and improving orchestration test clarity.
- Replaced `node-fetch` with `supertest` for API request testing across all test files. - Simplified test implementation by leveraging `supertest`'s declarative syntax. - Updated `package-lock.json` to include `supertest` dependency. - Improved test readability and maintainability through consistent HTTP client usage.
- Introduced new test suite for unified orchestration using `supertest` for HTTP requests. - Verified tool calls, sequential tool handling, and iteration limits in orchestration tests. - Added tests ensuring graceful handling of invalid tools and fallback responses. - Improved test reliability and reduced reliance on global mocks with isolated upstream services.
- Reduced test complexity by consolidating mocks and removing unused helpers. - Updated `iterative_orchestration.test.ts` to use minimal mocks while maintaining coverage. - Replaced intricate test logic with focused and concise assertions. - Removed reliance on `fireEvent` across relevant test files, enhancing consistency.
- Updated ESLint rules to allow empty `catch` blocks in specific files, permitting intentional error swallowing in tests/utilities. - Expanded ESLint configuration to include `test_utils/**/*.js` for proper linting. - Fixed inconsistent formatting in `iterative_orchestration.test.js`, ensuring cleaner syntax and alignment.
- Fixed inconsistent spacing and indentation across `ModelSelector.tsx` for cleaner code structure. - Replaced inline arrow function with named function `CodeRenderer` in `Markdown.tsx` for clarity. - Simplified inline code styling logic and ensured proper conditional calls for hooks. - Removed redundant comments and improved readability in Markdown renderer.
- Introduced socket tracking in `chatProxyTestUtils` to manage open connections during tests. - Ensured proper cleanup of lingering sockets to prevent handle leaks on server shutdown. - Updated `withServer` utility to include socket management for consistency and reliability.
- Separated `backend` and `frontend` into distinct jobs for isolation and clarity. - Added a new `check-results` job to ensure both `backend` and `frontend` jobs succeed before proceeding. - Adjusted cache dependency paths to align with individual jobs for improved efficiency.
…source cleanup Co-authored-by: qduc <11575015+qduc@users.noreply.github.com>
…ff440f91ee72 Fix open handles keeping Jest from exiting in iterative_orchestration.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.