Conversation
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
|
Why does this require multiple attempts in the screencast? |
|
I see that I won't be a youtuber... I was trying to show that users can undo/remove the selection |
Ah, makes sense! Can you remove the incorrect warning about "no vector layer selected" which is shown when undoing? |
Withalion
force-pushed
the
clipping-planes-tool
branch
3 times, most recently
from
d7a192d to
f6acd19
Compare
In that case, could you add a comment explaining this situation in the relevant part of the code please? |
|
It's not necessary as the PR with fix will come soon. (today/tomorrow)
|
After cross section is selected camera looks eastward at the selected cross section from distance to see it whole in profile view. User also sees highlighted area of cross section in 2D canvas.
Withalion
force-pushed
the
clipping-planes-tool
branch
from
900d711 to
22a84bf
Compare
| { | ||
| clear(); | ||
| QgsMessageBar *msgBar = QgisApp::instance()->messageBar(); | ||
| msgBar->pushInfo( QString(), tr( "The cross section is outside of the scene extent, please select a new one!" ) ); |
There was a problem hiding this comment.
nitpick. No need for a of here: The cross section is outside the scene extent, please select a new one!
|
Thanks @Withalion I did more testing and now I cannot define a cross-sections outside the scene. Regarding my other issue, I'm afraid I haven't understood your answer. If the cross-sections are already active and I change the 3D scene extent outside the cross-sections extent, I end up with an empty view. Is it supposed to work and it won't be covered by this PR? |
|
Anything related to changing extents, which also means moving the origin of the scene, is not covered by this PR. It will be covered by another one. Take this as a base PR for the clipping tool and we will hammer out any bugs with next PRs. |
In that case, update this PR once the handling of the origin of the scene is ready. This will ensure to merge a version without known issues or limitation. |
|
Handling of origin rebasing added in bb14eab |
|
@Withalion @wonder-sk I have just tried an up to date QGIS master and I can still reproduce the issue previously mentioned. Capture.video.du.2025-03-31.11-32-03.mp4Whether or not this issue would have been fixed, I also want to point out that I find it somewhat disrespectful to merge a PR without asking for my opinion, especially since I spent a lot of time reviewing and testing it. |
@ptitjano Understood. We didn't intend any disrespect, and apologize if it came across that way. We felt the PR was ready and didn't think you had further feedback, but we should have checked in. We'll be more mindful in the future. I am sure @Withalion will check your bug and fix if it can be replicated. |
zacharlie
added
the
Changelog
|
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
zacharlie
added
ChangelogHarvested
DelazJ
added
the
Needs Documentation
|
@Withalion |
|
@Withalion A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
7 participants
Description
This PR adds a new tool to create cross sections in 3D scene. User enables this tool in 3D window, selects the area on 2D canvas and after confirmation the 3D scene will be edited + the camera will change to profile view.
Left click-> adds pointBACKSPACEorDEL-> remove last step in selectionRight clickorESCAPE-> resets the selectionScreencast_20250320_005829.mp4
Funded by: Septima, Klimadatastyrelsen