Merged
Conversation
…um (which updates shader) and then update shader to keep correct
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
Collaborator
|
Any chance of a test for this? |
uclaros
added
Bug
Contributor
Author
|
Add test case |
Contributor
Author
|
@uclaros could you please trigger CI rerun here? It looks it failed for some weird reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrong order of operations caused
QgsMeshRendererScalarSettingsshaderto be recalculated from minimum and maximum instead of properly set up frommScalarColorRampShaderWidget. We first setup minimum maximum and then use shader frommScalarColorRampShaderWidget.Fixes #60864