fix(PyQt5toPyQt6): check if object has an attribute id#61221
Merged
nyalldawson merged 1 commit intoqgis:masterfrom Mar 28, 2025
Merged
fix(PyQt5toPyQt6): check if object has an attribute id#61221nyalldawson merged 1 commit intoqgis:masterfrom
nyalldawson merged 1 commit intoqgis:masterfrom
Conversation
Error fixed running the migration script on a certain plugin:
```python
Traceback (most recent call last):
File "/usr/local/bin/pyqt5_to_pyqt6.py", line 892, in <module>
raise SystemExit(main())
^^^^^^
File "/usr/local/bin/pyqt5_to_pyqt6.py", line 887, in main
ret |= fix_file(filename, not args.qgis3_incompatible_changes, dry_run)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/bin/pyqt5_to_pyqt6.py", line 461, in fix_file
visit_call(node, parent)
File "/usr/local/bin/pyqt5_to_pyqt6.py", line 338, in visit_call
and _node.args[0].func.id == "QDate"
^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Attribute' object has no attribute 'id'
```
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
nyalldawson
approved these changes
Mar 28, 2025
Contributor
|
Thanks @Guts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error fixed running the migration script on a certain plugin:
Description
[Replace this with some text explaining the rationale and details about this pull request]
cc @jmkerloch @florentfougeres @troopa81