Adding @wasade's parallel to per sample fasta #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josenavas
changed the title
Contributor
Author
|
Hang on a second - I just noticed that with a small change the user can specify if he wants fasta or fastq format (it may be useful for EBI submission) |
josenavas
changed the title
Contributor
Author
|
Awesome this is ready for review! |
antgonza
reviewed
Oct 11, 2016
qiita_files/demux.py
Outdated
| """ | ||
| if out_format == 'fastq': | ||
| formatter = format_fastq_record | ||
| file_name_fmt = "%s.fq" |
Contributor
Author
There was a problem hiding this comment.
I saw that in the tests 'fq' was used, that's why I used that, but no strong feelings so I can change.
Contributor
Author
|
@antgonza any clue on why coveralls is not working here? |
Member
|
nop, could you use the new structure that we have been using with other repos? |
Contributor
Author
|
Done - can you make sure that coveralls is enabled on this repo? I can't check on my coveralls page |
Member
|
I did and is on. |
Member
|
Anyway, from the log: Thus, merging. |
Contributor
|
bit late to the game but 👍 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.