BUG: Fix bug with Safari and MOI #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigning a function to document.ready doesn't seem to be supported in Safari, and thus the call to initialize MOI would never occurr. Using jQuery's proxy for ready seems to resolve this problem. Fixes qiita-spots#946
Contributor
|
👍 |
antgonza
added a commit
that referenced
this pull request
Apr 8, 2015
BUG: Fix bug with Safari and MOI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning a function to document.ready doesn't seem to be supported in Safari,
and thus the call to initialize MOI would never occurr (giving the impression
that WebSocket never started). Using jQuery's proxy for the ready callback
seems to resolve this problem.
Fixes #946