Creating generate_files function #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The CI is failing due to the stochastic failure in which the "longitude" columns magically disappears. I've restarted the build. |
Contributor
Author
|
Yay green! Can I have this reviewed? Thanks! |
Member
|
👍 |
ElDeveloper
added a commit
that referenced
this pull request
Apr 16, 2015
Creating generate_files function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of code duplication across the sample/prep template classes to generate the files; and in case of the sample template, there was a bug, since the extend function was modifying the contents of the template but it was not re-generating the qiime mapping file. There is another bug on the extend function, but I'll fix it in a different PR.
That being said, I just created a new function to encapsulate all the files creation and I removed the duplicated code and substitute it for a call to the new function.