Adding check_restrictions functionality

[josenavas]

This adds the check_restrictions functionality to the metadata template objects. This functionality is needed to check the restrictions from the GUI and disable functionality as needed.

Should be easy to review!

[antgonza]

Your friend pep(e)8 is calling ...

[antgonza]

Will it be better to do this in a set operation?

[josenavas]

Thanks @antgonza
Comments solved!

[coveralls]

Coverage increased (+0.02%) to 79.33% when pulling 55944f2 on josenavas:add-check-restriction into 01ac199 on biocore:master.

[antgonza]

👍

[wasade]

Why not just do {col for restriction in restrictions for col in restriction.columns}? The generator is immediately consumed so it isn't clear what the benefit of lazy eval is here

[josenavas]

I was just avoiding the double list comprehension, as sometimes it has been criticized. I think it is not too complicated, so I'll change it.

[wasade]

makes sense. in that case though, it would be better to just create the set
using two for loops. eg

cols = set()
for restriction in restrictions:
for col in restriction.columns:
cols.add(col)

On Mon, May 4, 2015 at 2:29 PM, josenavas notifications@github.com wrote:

In qiita_db/metadata_template/base_metadata_template.py
#1141 (comment):

•    Parameters
  

---

•    restrictions : list of Restriction
  

•        The restrictions to test if the template fulfills
  

•    Returns
  

---

•    set of str
  

•        The missing columns
  

•    """
  

•    def _col_iter():
  

•        for restriction in restrictions:
  

•            for col in restriction.columns:
  

•                yield col
  

I was just avoiding the double list comprehension, as sometimes it has
been criticized. I think it is not too complicated, so I'll change it.

—
Reply to this email directly or view it on GitHub
https://github.com/biocore/qiita/pull/1141/files#r29620275.

[wasade]

Just one comment, 👍 otherwise

[coveralls]

Coverage increased (+0.01%) to 79.32% when pulling 20eebdb on josenavas:add-check-restriction into 01ac199 on biocore:master.

[josenavas]

@antgonza @wasade any remaining comment in here?