Disable make processed data private

[josenavas]

Built on top of #1141

If the user is missing some of the columns that are required for our system, we don't allow it to request making the data private, since that's not possible until the missing columns are added. The system shows a message with the missing columns.

Fixes partially #1128

[coveralls]

Coverage increased (+0.01%) to 79.32% when pulling 0658af2 on josenavas:disable-make-processed-data-public into 01ac199 on biocore:master.

[antgonza]

Should it fully solve #1128 before is merged? If not, why?

[josenavas]

I can work extend this and just make a single PR, I was thinking on just making multiple, smaller PR.

[antgonza]

If that's the plan, should this be a new branch?

[josenavas]

IMOO is not leaving the master in an inconsistent state, but I can create it's own branch. What do you prefer, a single PR with all of it or 3 small PR in its own branch?

[antgonza]

I prefer 1 single PR, if not tooo complex.

[josenavas]

@antgonza I've included everything in this PR.

This now fixes #1128

[coveralls]

Coverage decreased (-0.14%) to 79.17% when pulling 9e360d8 on josenavas:disable-make-processed-data-public into 01ac199 on biocore:master.

[antgonza]

Thanks! Could you add test for the newly added code in: remove_add_prep_template, display_template
& PrepTemplatePanel.render?

[josenavas]

@antgonza I've created an issue since that involves refactor more code in qiita_pet: #1145

[antgonza]

Yup, @josenavas and I chatted and we agreed that adding those tests are a full refactor. Thus, 👍

[adamrp]

these values are in the __init__.py file, so you can import directly from qiita_db.metadata_template

[josenavas]

You're right! Fixed!

[adamrp]

Juts a minor comment, but 👍

[coveralls]

Coverage decreased (-0.15%) to 79.16% when pulling ed7bab8 on josenavas:disable-make-processed-data-public into 01ac199 on biocore:master.

[coveralls]

Changes Unknown when pulling 919bd88 on josenavas:disable-make-processed-data-public into * on biocore:master*.

[josenavas]

@adamrp any remaining comment?

[josenavas]

I have 2 👍 @adamrp can you merge if your are ok with the code? Thanks!

[josenavas]

AARGGGGH!!! I though this PR was merged!!! This is pretty bad as my current PR modifies some of the pages modified here! Can I get this merged so I can try to solve the potential hell of merge conflicts and complete my work? I'm surprised that I don't have any merge conflict on this one...

I'll be working on this tomorrow morning and this is kind of blocking further development on my other issue. @antgonza or @adamrp can you merge?

[josenavas]

Thanks @ElDeveloper