Stop writing empty files and improve EBI tests

[adamrp]

Fix #1070

[josenavas]

@adamrp it looks like there are legitimate test failures

[adamrp]

Getting the same build failures that are over in #1175. Not sure exactly why this just started to be a problem, but the error message is related to pandas, which had an update on May 11, so I'm suspecting something there. The only thing I could find in the changelog related to this warning being raised is from an 8 Oct 2014 release (version 0.15).

Anyways, I think the issue is that because the warning we're looking for isn't the first warning, it's erroring (according to the nympy documentation on assert_warns), so we might have to take a different approach, perhaps something that borrows from this SO post.

[ElDeveloper]

Although less desirable, we could also just stick with an older version
of Pandas i.e. the one that was working just fine.

On (May-13-15|12:45), adamrp wrote:

Getting the same build failures that are over in #1175. Not sure exactly why this just started to be a problem, but the error message is related to pandas, which had an update on May 11, so I'm suspecting something there. The only thing I could find in the changelog related to this warning being raised is from an 8 Oct 2014 release (version 0.15).

Anyways, I think the issue is that because the warning we're looking for isn't the first warning, it's erroring (according to the nympy documentation on assert_warns), so we might have to take a different approach, perhaps something that borrows from this SO post.

---

Reply to this email directly or view it on GitHub:
#1172 (comment)

[squirrelo]

I think I've traced the issue to here, but I don't know enough about Pandas to fix the issue.

[coveralls]

Coverage decreased (-0.04%) to 79.24% when pulling 6f516ed on adamrp:ebi_empty_files-issue-1070 into da407f6 on biocore:master.

[adamrp]

Ready for review

[josenavas]

Can you use join instead of string concatenation?

[josenavas]

you can even use the partial function, so it will simplify the following 3 lines.

[josenavas]

Thanks @adamrp , just a small comment.

[adamrp]

Thanks @josenavas, done!

[coveralls]

Coverage decreased (-0.05%) to 79.23% when pulling dd99ee5 on adamrp:ebi_empty_files-issue-1070 into 2d71d7d on biocore:master.

[josenavas]

👍