Skip to content

Conversation

@squirrelo
Copy link
Contributor

The expected file had messy floats, but the newest pandas fixes that, so the test file was changed to reflect this, and the checksum updated and verified on the test file.

Adam Robbins-Pianka and others added 2 commits May 15, 2015 12:03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want these changes in here

@adamrp
Copy link
Contributor

adamrp commented May 15, 2015

👍 if tests pass

@ElDeveloper
Copy link
Contributor

👍 ... though I'm kinda worried that this is only going to work for newer versions of pandas, should we also change setup.py and qiita_test_install to force to require this version? That way we shouldn't encounter this problem ... I hope.

@adamrp
Copy link
Contributor

adamrp commented May 15, 2015

Good point @ElDeveloper. Yes, I think we should.

On Fri, May 15, 2015 at 4:25 PM, Yoshiki Vázquez Baeza <
notifications@github.com> wrote:

[image: 👍] ... though I'm kinda worried that this is only going to
work for newer versions of pandas, should we also change setup.py and
qiita_test_install to force to require this version? That way we shouldn't
encounter this problem ... I hope.


Reply to this email directly or view it on GitHub
#1186 (comment).

@squirrelo
Copy link
Contributor Author

Weirdly, I just went back to pandas 0.15.2 and the tests passed. I have no idea why, but it does.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.29% when pulling 9fcd284 on squirrelo:fix-pandas-issues into da407f6 on biocore:master.

@squirrelo
Copy link
Contributor Author

GREEN!

@adamrp
Copy link
Contributor

adamrp commented May 15, 2015

Sasquatch bug... I think we should probably merge this now, but investigate what the minimum version of pandas is that we should require.

@ElDeveloper
Copy link
Contributor

ElDeveloper added a commit that referenced this pull request May 15, 2015
Cast index to array to avoid pandas warning, and fix file checksum
@ElDeveloper ElDeveloper merged commit ea328af into qiita-spots:master May 15, 2015
@antgonza
Copy link
Member

My guess is that is passes because you also fixed the messed up numbers ...

@adamrp adamrp mentioned this pull request May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants