-
Notifications
You must be signed in to change notification settings - Fork 79
Cast index to array to avoid pandas warning, and fix file checksum #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Better way to get an array of the index Thanks @ElDeveloper!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you want these changes in here
|
👍 if tests pass |
|
👍 ... though I'm kinda worried that this is only going to work for newer versions of pandas, should we also change setup.py and qiita_test_install to force to require this version? That way we shouldn't encounter this problem ... I hope. |
|
Good point @ElDeveloper. Yes, I think we should. On Fri, May 15, 2015 at 4:25 PM, Yoshiki Vázquez Baeza <
|
|
Weirdly, I just went back to pandas 0.15.2 and the tests passed. I have no idea why, but it does. |
|
GREEN! |
|
Sasquatch bug... I think we should probably merge this now, but investigate what the minimum version of pandas is that we should require. |
Cast index to array to avoid pandas warning, and fix file checksum
|
My guess is that is passes because you also fixed the messed up numbers ... |

The expected file had messy floats, but the newest pandas fixes that, so the test file was changed to reflect this, and the checksum updated and verified on the test file.