1084 populate db #1202
Merged
1084 populate db #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent (they're RawData w/o PrepTemplate
Member
|
👍 as we can not really review, I would merge but rather wait to see someone else opinion ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1201 (review-merge that one first).
With the database changes, populate_test_db.sql was creating an inconsistent DB: there was raw data not associated with any prep template.
Since it was a lot of work to add prep templates to add those raw data, and those raw data where mainly used in the qiita_ware tests, I removed those raw data so populate is easier to manage.
Tests are still expected to fail, since I still haven't changed any code.