Skip to content

Conversation

@AmandaBirmingham
Copy link
Contributor

Improves the display of prep info in the study page side-bar as specified in #3054, adding for each prep the total number of samples as well as the creation and modification date, which artifacts have been produced, and whether it is ready for submission. Displays preps in ascending order by creation date. See example below.

preps_display_w_dates_mod

@coveralls
Copy link

coveralls commented Jun 17, 2021

Coverage Status

Coverage increased (+0.01%) to 91.16% when pulling b00bfa6 on AmandaBirmingham:dev into 4e15351 on qiita-spots:dev.

Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for putting together, some minor suggestions, see below:

  • if the prep has been submitted, no need to show that is OK to submit
  • the comma (,) between the number of samples and the samples submitted has a space, can you remove it?
  • I don't think we need the word Progress in the progress line, perhaps worth removing?

Screen Shot 2021-06-17 at 3 00 46 PM

@AmandaBirmingham
Copy link
Contributor Author

@antgonza Thank you! I will remove the word "Progress" and the space before the comma, as you described. I need a bit more guidance to know when to put in the "ok to submit" entry: should I leave it off if the is_submitted_to_ebi property of the prep is True? Or?

@antgonza
Copy link
Member

Thank you; BTW there are also spaces after the commas in the Progress elements.

That's a good question, I think we should remove the "OK to submit" for now, to avoid confusion, and add once we have this: #2721 ready.

@AmandaBirmingham
Copy link
Contributor Author

@antgonza Ok, can do. How does this look?

Screen Shot 2021-06-17 at 3 26 12 PM

(I know it kinda looks like there are still spaces after the green checkmarks, but there really aren't :)

@antgonza
Copy link
Member

Looks great, could you push to your branch so the tests run and, if everything passes, I can merge? Thank you.

@AmandaBirmingham
Copy link
Contributor Author

@antgonza should be ready for you!

Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@antgonza antgonza merged commit cd25370 into qiita-spots:dev Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants