-
Notifications
You must be signed in to change notification settings - Fork 79
fix #3054 #3115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3054 #3115
Conversation
Thank you @sjanssen2. Well, (1) it's easy, and (2) I'm currently working on regular fixes for the next deployment AKA perfect timing. Thank you. Merging.
antgonza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for putting together, some minor suggestions, see below:
- if the prep has been submitted, no need to show that is OK to submit
- the comma (,) between the number of samples and the samples submitted has a space, can you remove it?
- I don't think we need the word
Progressin the progress line, perhaps worth removing?
|
@antgonza Thank you! I will remove the word "Progress" and the space before the comma, as you described. I need a bit more guidance to know when to put in the "ok to submit" entry: should I leave it off if the |
|
Thank you; BTW there are also spaces after the commas in the Progress elements. That's a good question, I think we should remove the "OK to submit" for now, to avoid confusion, and add once we have this: #2721 ready. |
|
@antgonza Ok, can do. How does this look? (I know it kinda looks like there are still spaces after the green checkmarks, but there really aren't :) |
|
Looks great, could you push to your branch so the tests run and, if everything passes, I can merge? Thank you. |
|
@antgonza should be ready for you! |
antgonza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!


Improves the display of prep info in the study page side-bar as specified in #3054, adding for each prep the total number of samples as well as the creation and modification date, which artifacts have been produced, and whether it is ready for submission. Displays preps in ascending order by creation date. See example below.