disable getauxval HWCAP value for ARM64, which indicates Atomics supp…#1562
Merged
elicn merged 1 commit intoqilingframework:devfrom Apr 20, 2025
Merged
Conversation
…ort, which is however not implemented in current Unicorn versions
elicn
approved these changes
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
This change fixes the ARM64 elf loader to not indicate that atomics instructions are supported. The current QEMU version by Unicorn does not support these atomics call, therefore we should also not indicate to processes that this is a good idea.
getauxval values are determined by the kernel documentation like this. Therefore, we need to ensure that
HWCAP_ATOMICSis not set.Mostly the processes do check for support judging from these values like this (example from LIBC). The variable
_aarch64_have_lse_atomicsis controlled by getauxval.