Skip to content

Conversation

@YangSen-qn
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #429 into master will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #429      +/-   ##
============================================
+ Coverage     72.63%   72.64%   +0.01%     
+ Complexity      855      853       -2     
============================================
  Files            73       73              
  Lines          4538     4537       -1     
  Branches        672      671       -1     
============================================
  Hits           3296     3296              
+ Misses          817      816       -1     
  Partials        425      425              
Impacted Files Coverage Δ Complexity Δ
.../com/qiniu/android/collect/UploadInfoReporter.java 67.74% <0.00%> (-1.62%) 28.00 <0.00> (-1.00)
...droid/http/metrics/UploadRegionRequestMetrics.java 80.64% <ø> (ø) 10.00 <0.00> (ø)
.../qiniu/android/http/metrics/UploadTaskMetrics.java 83.72% <ø> (ø) 13.00 <0.00> (ø)
.../java/com/qiniu/android/storage/UploadOptions.java 63.41% <ø> (-0.88%) 10.00 <0.00> (ø)
.../java/com/qiniu/android/storage/UploadManager.java 81.75% <75.00%> (+2.98%) 33.00 <2.00> (ø)
.../qiniu/android/http/request/HttpSingleRequest.java 80.61% <85.71%> (-1.39%) 9.00 <4.00> (ø)
...roid/http/request/httpclient/SystemHttpClient.java 75.77% <88.00%> (+0.65%) 21.00 <7.00> (-1.00) ⬆️
...droid/http/metrics/UploadSingleRequestMetrics.java 93.75% <100.00%> (+0.41%) 17.00 <4.00> (+1.00)
...iniu/android/http/request/httpclient/ByteBody.java 100.00% <100.00%> (ø) 6.00 <1.00> (+1.00)
...ain/java/com/qiniu/android/storage/BaseUpload.java 77.45% <100.00%> (+0.22%) 23.00 <0.00> (ø)
... and 3 more

long headerLength = 0;
long bodyLength = 0 ;
if (request.allHeaders != null){
if (request != null && request.allHeaders != null){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议可以在最开始判断request 是否是 null,如果是,直接返回

@bachue bachue merged commit 9024b42 into qiniu:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants