Skip to content

Conversation

@peteryuanpan
Copy link
Contributor

1.表单上传增加方法 putWithForm,支持带inputStream上传
2.增加FormUploadTest2测试类
3.修改StreamingTest类,使测试通过
4.增加IOUtils类,用于inputStream转byte[]
4.修复已知问题

* @throws QiniuException
* @throws IOException
*/
public Response put(InputStream inputStream, String key, String token) throws QiniuException, IOException {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得这个不需要,已经有一个类似的函数签名了:
public Response put(InputStream stream, String key, String token, StringMap params, String mime) throws QiniuException
让这个调用 put(inputStream, -1, key, token, params, mime, false);
这个带inputStream 和 size的函数 应当是最基本的 函数
那些传递file,filepath等参数的函数都可以调用它。因为file和filepath都可以转化为inputstream且都能知道size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,去掉

* @throws QiniuException
* @throws IOException
*/
public Response put(InputStream inputStream, long size, String key, String token) throws QiniuException, IOException {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个暂时不需要

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,去掉

@@ -0,0 +1,73 @@
package test.com.qiniu.storage;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个test2很怪,能不能合并到test1里?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已合并

@peteryuanpan peteryuanpan requested a review from sxci March 13, 2019 10:38
@sxci sxci merged commit f7eb77d into master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants