优化项目结构 #504
Merged
优化项目结构 #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 42.21% 43.22% +1.00%
==========================================
Files 9 15 +6
Lines 514 849 +335
Branches 113 155 +42
==========================================
+ Hits 217 367 +150
- Misses 285 472 +187
+ Partials 12 10 -2
Continue to review full report at Codecov.
|
yinxulai
commented
Apr 22, 2021
lzfee0227
reviewed
Apr 22, 2021
| export * from './observable' | ||
|
|
||
| export * from './base64' | ||
| export * from './helper' |
There was a problem hiding this comment.
index + export 可以绕过 helper
lzfee0227
reviewed
Apr 22, 2021
src/utils/compress.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import { EXIF } from 'exif-js' | |||
| import { createObjectURL, getTransform } from './utils' | |||
| import { createObjectURL, getTransform } from '.' | |||
There was a problem hiding this comment.
循环引用？
好像不止一个这种东西 check 一下
lzfee0227
reviewed
Apr 22, 2021
|
|
||
| export { urlSafeBase64Encode, urlSafeBase64Decode } from './base64' | ||
|
|
||
| export { CompressResult } from './compress' |
lzfee0227
reviewed
Apr 22, 2021
Comment on lines
1
to
6
| import Resume from './resume' | ||
| import Direct from './direct' | ||
| import { UploadOptions, UploadHandler } from './base' | ||
| import Logger from '../logger' | ||
| import { MB } from '../utils' | ||
| import { UploadCompleteData } from '../api' | ||
| import { CustomError, Observable, IObserver, MB } from '../utils' | ||
| import { Config, Extra, UploadHandler, UploadOptions, UploadProgress } from './base' |
lzfee0227
reviewed
Apr 22, 2021
src/upload/index.ts
Outdated
| * @param config 上传任务的配置 | ||
| * @returns 返回用于上传任务的可观察对象 | ||
| */ | ||
| export function upload( |
There was a problem hiding this comment.
default 应该换成这个？
upload 模块的缺省导出是 upload 很正常？
我看其他的东西也没导出
lzfee0227
reviewed
Apr 22, 2021
Comment on lines
1
to
3
| import { Pool } from '../pool' | ||
| import { uploadChunk, uploadComplete, initUploadParts, UploadChunkData } from '../api' | ||
| import Base, { Progress, UploadInfo, Extra } from './base' | ||
| import * as utils from '../utils' |
lzfee0227
reviewed
Apr 23, 2021
src/utils/base64.ts
Outdated
|
|
||
| export function utf8Encode(argString: any) { | ||
| // https://github.com/locutusjs/locutus/blob/master/src/php/xml/utf8_encode.js | ||
| function utf8Encode(argString: any) { |
There was a problem hiding this comment.
NIP: 为什么 argString 的类型不是 string = =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.