site 细节优化 #543
Merged
site 细节优化 #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
=======================================
Coverage 74.39% 74.39%
=======================================
Files 21 21
Lines 1117 1117
Branches 210 210
=======================================
Hits 831 831
Misses 286 286 Continue to review full report at Codecov.
|
nighca
previously approved these changes
Nov 23, 2021
site/src/components/Layout/index.tsx
Outdated
| import qiniuLogo from './assets/logo.svg' | ||
| import classnames from './style.less' | ||
|
|
||
|
|
site/src/components/Layout/index.tsx
Outdated
| import classnames from './style.less' | ||
|
|
||
|
|
||
| function OfficialSite() { |
There was a problem hiding this comment.
NIP:
Suggested change
| function OfficialSite() { | |
| function Copyright() { |
lzfee0227
reviewed
Nov 23, 2021
Comment on lines
+43
to
+44
| * [JavaScript SDK 在线示例 V3](https://js-sdk-demo.qiniu.io) | ||
| * [JavaScript SDK 在线示例 V2](http://jssdk-v2.demo.qiniu.io) |
There was a problem hiding this comment.
这 v2 v3 语义不是很明确，一开始根本想不出来是 js sdk 的版本… 还以为是 demo 的版本 = =
文档开头说的 2.x 3.x 这里怎么就成了 v2 v3 术语不配套？
而且对这个文档来说，v3 本来就是配套的，v2 才是奇怪的那个… 比如上面就有 v2 的文档入口，这个为什么是例外
| target="_blank" | ||
| href="http://jssdk-v2.demo.qiniu.io" | ||
| > | ||
| V2版本 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.