-
Notifications
You must be signed in to change notification settings - Fork 14
更新readme,细化直播配置 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
更新readme,细化直播配置 #57
Conversation
Summary of ChangesHello @callmefisher, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在通过更新 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次更新主要是在 README.md 文件中为直播功能增加了两种鉴权模式的配置说明。我注意到新添加的文档部分格式可以优化,以便于用户阅读和复制代码片段。我已经提出了具体的修改建议,主要是将说明文字和 JSON 配置代码块分开,并使用正确的 Markdown 语法来增强可读性。
|
|
||
| ``` | ||
| 如果只使用直播功能时,支持两种鉴权模式 | ||
| 1 配置QINIU_ACCESS_KEY/QINIU_SECRET_KEY | ||
| { | ||
| "mcpServers": { | ||
| "qiniu": { | ||
| "command": "uvx", | ||
| "args": [ | ||
| "qiniu-mcp-server" | ||
| ], | ||
| "env": { | ||
| "QINIU_ACCESS_KEY": "YOUR_ACCESS_KEY", | ||
| "QINIU_SECRET_KEY": "YOUR_SECRET_KEY" | ||
| }, | ||
| "disabled": false | ||
| } | ||
| } | ||
| } | ||
| 2 可在七牛直播控制台获取apikey后,配置QINIU_LIVE_API_KEY | ||
| { | ||
| "mcpServers": { | ||
| "qiniu": { | ||
| "command": "uvx", | ||
| "args": [ | ||
| "qiniu-mcp-server" | ||
| ], | ||
| "env": { | ||
| "QINIU_LIVE_API_KEY": "YOUR_LIVE_API_KEY" | ||
| }, | ||
| "disabled": false | ||
| } | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这部分新增的说明格式可以优化一下,以提高可读性。目前,说明文字和 JSON 配置示例被包裹在一个大的代码块中,这使得文本部分也以等宽字体显示,并且 JSON 没有语法高亮。
建议将说明文字作为普通 Markdown 文本,并将每个 JSON 示例放入独立的 json 代码块中。这样不仅结构更清晰,用户也更容易复制配置。我还对文本做了一些微调,并修正了 JSON 中的缩进问题。
> **注意**:如果只使用直播功能,可选择以下两种鉴权模式之一。
**模式一:使用 Access Key / Secret Key**
配置 `QINIU_ACCESS_KEY` 和 `QINIU_SECRET_KEY`。
```json
{
"mcpServers": {
"qiniu": {
"command": "uvx",
"args": [
"qiniu-mcp-server"
],
"env": {
"QINIU_ACCESS_KEY": "YOUR_ACCESS_KEY",
"QINIU_SECRET_KEY": "YOUR_SECRET_KEY"
},
"disabled": false
}
}
}模式二:使用直播 API Key
在七牛直播控制台获取 API Key 后,配置 QINIU_LIVE_API_KEY。
{
"mcpServers": {
"qiniu": {
"command": "uvx",
"args": [
"qiniu-mcp-server"
],
"env": {
"QINIU_LIVE_API_KEY": "YOUR_LIVE_API_KEY"
},
"disabled": false
}
}
}
No description provided.