[WIP] Removed bounds everywhere! #320
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #190 it was suggested to remove
boundsfrom all over the code. We haven't decided whether it's a good idea, and until now it's been done only for T1. I've decided to promote the topic by creating this PR, whereboundsis aggressively removed from all the experiments, without checking the consequences.Details and comments
Things that remain to be done (I'll need help from experiment owners for some of them):
boundsparameter is RB. The other tutorials need to rerun as well because there can be small changes in results, but I don't expect issues.More details about the failing tests:
test_run_single_curve_fail(intest_curve_fit.py) verifies correct reaction when fit fails by fitting with infeasible boundaries. Another way of failing the fit is now required.