Changing the way default bounds are handled in RB

[gadial]

Summary

This PR addresses issue #103.

Details and comments

[yaelbh]

A related question is whether we expect to remove bounds (#190, #320)

[yaelbh]

I think it's correct, but it will help if @nkanazawa1989 also takes a look

[nkanazawa1989]

Thanks, this looks correct to me.

[nkanazawa1989]

Sorry, I misunderstood the issue.

[nkanazawa1989]

It seems like the issue and PR are outdated by #390. Now the bounds and init guesses are set via set_if_empty method. Usually the default values entering to the user options are None and actual numbers are provided in the guess method (this is because some bounds are also computed based on the curve data, IRB and RB is just a special case that we know these numbers without having actual data). I think what is implemented now is correct behavior and we don't need to change it.

If user intentionally provides these bounds or guesses, that values are passed to the user options dict and the dict protects itself from updating by algorithmic bounds or guesses.

[yaelbh]

@gadial Do you agree with @nkanazawa1989 ? Should we close this?

[nkanazawa1989]

Agreed.