Update sqrt_lorentzian #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggerdj
reviewed
Feb 7, 2022
Contributor
eggerdj
left a comment
eggerdj
left a comment
There was a problem hiding this comment.
This gives the same result for kappa > 0 but deviates for kappa < 0 (which is typically un-physical anyways). Should we maintain the absolute value? This would make sense since physically we are looking for a function which is the fourier transform of a right-sided decaying exponential (https://www.thefouriertransform.com/pairs/decayingexponential.php). I.e. we excite the qubit or resonator with a pulse and then the energy decays.
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
Update sqrt_lorentzian to be real-valued form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #650
Details and comments
New function in real-valued form is
amp * kappa / np.sqrt(kappa**2 + 4 * (x - x0) ** 2) + baselinewhich passed my local tests.