Skip to content

Update sqrt_lorentzian #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Update sqrt_lorentzian #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8598323
update fit function
nkanazawa1989 Feb 7, 2022
d1a7ca2
add abs
nkanazawa1989 Feb 7, 2022
ea5a931
Merge branch 'main' into upgrade/update_sqrt_lorentzian
nkanazawa1989 Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qiskit_experiments/curve_analysis/fit_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ def sqrt_lorentzian(
r"""Square-root Lorentzian function for spectroscopy.

.. math::
y = {\rm amp}{\rm abs}\left(\frac{1}{1 + 2i(x - x0)/\kappa}\right) + {\rm baseline}
y = \frac{{\rm amp} |\kappa|}{\sqrt{\kappa^2 + 4(x -x_0)^2}} + {\rm baseline}
"""
return amp * np.abs(1 / (1 + 2.0j * (x - x0) / kappa)) + baseline
return amp * abs(kappa) / np.sqrt(kappa**2 + 4 * (x - x0) ** 2) + baseline


def cos_decay(
Expand Down
2 changes: 1 addition & 1 deletion qiskit_experiments/curve_analysis/standard_analysis/resonance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class ResonanceAnalysis(curve.CurveAnalysis):
x, amp=a, kappa=kappa, x0=freq, baseline=b
),
plot_color="blue",
model_description=r"a abs(1 / (1 + 2i * (x - x_0) / \kappa)) + b",
model_description=r"a |\kappa| / sqrt(kappa^2 + 4 * (x - x_0)^2) + b",
)
]

Expand Down